From: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
Subject: | Re: Improvements and additions to COPY progress reporting |
Date: | 2021-02-12 11:23:34 |
Message-ID: | CAEze2WiTSjepqc-JO29yaydeXdgXeqxJ1Hi-DAMvfzKqnnje2w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, 11 Feb 2021 at 15:44, Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
>
> On Thu, Feb 11, 2021, 8:08 PM Josef Šimánek <josef(dot)simanek(at)gmail(dot)com> wrote:
>> I have split it since it should be the start of progress reporting
>> testing at all. If you better consider this as part of COPY testing,
>> feel free to move it to already existing copy testing related files.
>> There's no real reason to keep it separated if not needed.
>
>
> +1 to move those test cases to existing copy test files.
Thanks for your reviews. PFA v4 of the patchset, in which the tests
are put into copy.sql (well, input/copy.source). This also adds tests
for correctly reporting COPY ... FROM 'file'.
I've changed the notice-alerted format from manually naming each
column to calling to_jsonb and removing the unstable columns from the
reported value; this should therefore be stable and give direct notice
to changes in the view.
With regards,
Matthias van de Meent.
Attachment | Content-Type | Size |
---|---|---|
v4-0004-Add-a-command-column-to-the-copy-progress-view.patch | text/x-patch | 4.2 KB |
v4-0006-Add-copy-progress-reporting-regression-tests.patch | text/x-patch | 4.7 KB |
v4-0002-Rename-lines-to-tuples-in-COPY-progress-reporting.patch | text/x-patch | 5.7 KB |
v4-0003-Add-backlinks-to-progress-reporting-documentation.patch | text/x-patch | 7.4 KB |
v4-0005-Add-a-io_target-column-to-the-copy-progress-view.patch | text/x-patch | 6.3 KB |
v4-0001-Add-progress-reporting-for-excluded-rows.patch | text/x-patch | 4.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Zhihong Yu | 2021-02-12 12:09:40 | Re: Parallel INSERT (INTO ... SELECT ...) |
Previous Message | Amit Kapila | 2021-02-12 10:37:17 | Re: [HACKERS] logical decoding of two-phase transactions |