From: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
---|---|
To: | |
Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
Subject: | Re: Improvements and additions to COPY progress reporting |
Date: | 2021-02-12 12:10:46 |
Message-ID: | CAEze2Wh_ohsJuRQ7kkCnfZWNqHXLsJCFsKzRauoGNeNgG=eosg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, 12 Feb 2021 at 12:23, Matthias van de Meent
<boekewurm+postgres(at)gmail(dot)com> wrote:
>
> On Thu, 11 Feb 2021 at 15:44, Bharath Rupireddy
> <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> >
> >
> > On Thu, Feb 11, 2021, 8:08 PM Josef Šimánek <josef(dot)simanek(at)gmail(dot)com> wrote:
> >> I have split it since it should be the start of progress reporting
> >> testing at all. If you better consider this as part of COPY testing,
> >> feel free to move it to already existing copy testing related files.
> >> There's no real reason to keep it separated if not needed.
> >
> >
> > +1 to move those test cases to existing copy test files.
>
> Thanks for your reviews. PFA v4 of the patchset, in which the tests
> are put into copy.sql (well, input/copy.source). This also adds tests
> for correctly reporting COPY ... FROM 'file'.
PFA v5, which fixes a failure in the pg_upgrade regression tests due
to incorrect usage of @abs_builddir(at)(dot) I had the changes staged, but
forgot to add them to the patches.
Sorry for the noise.
-Matthias
Attachment | Content-Type | Size |
---|---|---|
v5-0006-Add-copy-progress-reporting-regression-tests.patch | text/x-patch | 2.1 KB |
v5-0005-Add-copy-progress-reporting-regression-tests.patch | text/x-patch | 4.7 KB |
v5-0002-Add-backlinks-to-progress-reporting-documentation.patch | text/x-patch | 7.4 KB |
v5-0004-Add-a-io_target-column-to-the-copy-progress-view.patch | text/x-patch | 6.3 KB |
v5-0003-Add-a-command-column-to-the-copy-progress-view.patch | text/x-patch | 4.2 KB |
v5-0001-Rename-lines-to-tuples-in-COPY-progress-reporting.patch | text/x-patch | 5.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Erik Rijkers | 2021-02-12 12:33:57 | logical replication seems broken |
Previous Message | Zhihong Yu | 2021-02-12 12:09:40 | Re: Parallel INSERT (INTO ... SELECT ...) |