Re: SQL Property Graph Queries (SQL/PGQ)

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Cc: Amit Langote <amitlangote09(at)gmail(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, Ajay Pal <ajay(dot)pal(dot)k(at)gmail(dot)com>, Imran Zaheer <imran(dot)zhir(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SQL Property Graph Queries (SQL/PGQ)
Date: 2025-03-12 04:31:38
Message-ID: CAExHW5vn-iToe56NTV3xNROsRiYcqppm0EFGaBu5_99-Z82jGQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks

On Tue, Mar 11, 2025 at 7:51 PM Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:

>
> Here is a new version with Amit's fix and my trivial refactors.
>
> 0001-0010 is the same as Ashutosh's last email
> 0011 is Amit's fix of the crash in ExecCheckPermissions

I think that fix is correct and it fixes the crash. I need to think
more about it - especially whether there are more places where we are
missing RTE_GRAPH_TABLE. But will do that as time permits.

> 0012 is a trivial fix that remove the test with default collation, or
> it will fail CI, see[1]
> 0013-0015 are some trivial fix and refactor, feel free to incorporate
> or drop when you review them.
>
> [1]: https://api.cirrus-ci.com/v1/artifact/task/5290818690351104/testrun/build/testrun/regress/regress/regression.diffs
>

Thanks Junwang. I have added your patches to my local repository. Next
time I post an updated set, I will post it along with your patches.
Will merge them into the original patches as time permits.

--
Best Wishes,
Ashutosh Bapat

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2025-03-12 04:34:49 Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
Previous Message David G. Johnston 2025-03-12 04:22:47 Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.