| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, davinder singh <davindersingh2692(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PG compilation error with Visual Studio 2015/2017/2019 |
| Date: | 2020-04-22 14:06:29 |
| Message-ID: | CAEudQArZHcK_dR4UiQyCqVi11U4c-bq=xqD5k-FNe7zHVnSVig@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em qua., 22 de abr. de 2020 às 08:43, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
escreveu:
> On Tue, Apr 21, 2020 at 5:32 PM Juan José Santamaría Flecha
> <juanjo(dot)santamaria(at)gmail(dot)com> wrote:
> >
> > On Tue, Apr 21, 2020 at 12:41 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
> >>
>
6. I have additionally done some cosmetic changes in the attached patch.
>
I made some style changes too.
1. Change:
strcpy(iso_lc_messages, "C");
to
iso_lc_messages[0] = 'C';
iso_lc_messages[1] = '\0';
2. Remove vars hyphen and underscore;
3. Avoid call second wcsrchr, if hyphen is not found.
If it's not too much perfectionism.
regards,
Ranier Vilela
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-PG-compilation-error-with-VS-2015-2017-2019_v12.patch | application/octet-stream | 6.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jehan-Guillaume de Rorthais | 2020-04-22 14:14:20 | Re: [BUG] non archived WAL removed during production crash recovery |
| Previous Message | Robert Haas | 2020-04-22 13:52:53 | Re: design for parallel backup |