From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
---|---|
To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Small miscellaneus fixes (Part II) |
Date: | 2023-01-17 11:26:11 |
Message-ID: | CAEudQAr=f+_6Vja8vFE8+pZ9ppQXwtgXcLTTcRv37wch5oHVgw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Em ter., 17 de jan. de 2023 às 04:37, John Naylor <
john(dot)naylor(at)enterprisedb(dot)com> escreveu:
>
> On Mon, Jan 16, 2023 at 1:28 PM John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
> wrote:
> >
> >
> > I wrote:
> > > ...but arguably the earlier check is close enough that it's silly to
> assert in the "else" branch, and I'd be okay with just nuking those lines.
> Another thing that caught my attention is the assumption that unsetting a
> bit is so expensive that we have to first check if it's set, so we may as
> well remove "IS_BRACKET(Np->Num)" as well.
> >
> > The attached is what I mean. I'll commit this this week unless there are
> objections.
>
> I've pushed this and the cosmetic fix in pg_dump. Those were the only
> things I saw that had some interest, so I closed the CF entry.
>
Thanks for the commits.
regards,
Ranier Vilela
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2023-01-17 11:36:02 | Re: xml2: add test for coverage |
Previous Message | Alvaro Herrera | 2023-01-17 11:23:23 | Re: Helper functions for wait_for_catchup() in Cluster.pm |