Re: [HACKERS] Fix warnings and typo in dshash

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Fix warnings and typo in dshash
Date: 2018-02-11 20:23:43
Message-ID: CAEepm=3TuBb_LKfH7+AnkD8ZKyb+Facz_=hMNoHnxCEUxEpCyw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 4, 2017 at 2:18 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Sun, Sep 3, 2017 at 2:56 PM, Thomas Munro
> <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>> I think it should be (size_t) 1, not UINT64CONST(1). See attached.
>
> Okay, that makes sense. Do you think we should also change type
> casting in BUCKETS_PER_PARTITION so that we are consistent?

+1

Here's a patch to fix that. I was reminded to come back and tidy this
up when I spotted a silly mistake in a nearby comment, also fixed in
this patch.

--
Thomas Munro
http://www.enterprisedb.com

Attachment Content-Type Size
0001-Minor-clean-up-in-dshash.-c-h.patch application/octet-stream 1.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2018-02-11 21:36:44 Re: ALTER TABLE ADD COLUMN fast default
Previous Message Sand Stone 2018-02-11 19:34:52 persistent read cache