From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org> |
Subject: | Re: GRANT USAGE ON SEQUENCE missing from psql command completion |
Date: | 2015-09-01 02:42:01 |
Message-ID: | CAEepm=2O2snRgxG2u=+kpdc9Nd_kM_AJBjL15RtY-+8CzJVidA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Thu, Aug 20, 2015 at 3:20 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:
>
> On Thu, Aug 20, 2015 at 12:10 PM, Thomas Munro <
> thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>
>> On Thu, Aug 20, 2015 at 2:54 PM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
>> > Versions tested: 9.4.4, 9.5a2
>> >
>> > Steps to reproduce:
>> >
>> > 1. psql to a database with sequences
>> >
>> > 2. type "grant usage on " and hit tab
>> >
>> > 3. "sequence" does not appear
>> >
>> > 4. type "grant usage on sequence " and hit tab
>> >
>> > 5. completes with word "to" which is incorrect.
>>
>> Here's a patch for that.
>>
>
> Don't we want to add TABLE as well? That's the default with just ON but it
> seems useful to me to show up only a list of tables without all those
> keywords.
>
Agreed. I noticed a couple more things:
1. GRANT/REVOKE * ON DATABASE/SEQUENCE/TABLE/... * TO/FROM <tab> doesn't
suggest roles, as it should.
2. GRANT/REVOKE * ON ALL FUNCTIONS/SEQUENCES/TABLES IN SCHEMA ... isn't
supported and might as well be.
New patch attached to address those. I added this to the open commitfest.
--
Thomas Munro
http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
tab-complete-grant.patch | application/octet-stream | 5.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2015-09-01 02:46:06 | Re: BUG #13599: Backup/Restore Documentation Bug |
Previous Message | Michael Paquier | 2015-09-01 01:43:41 | Re: BUG #13594: pg_ctl.exe redirects stderr to Windows Events Log if stderr is redirected to pipe |