From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
---|---|
To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Creating a DSA area to provide work space for parallel execution |
Date: | 2016-11-25 12:55:12 |
Message-ID: | CAEepm=1KXKe-pVAHMBxJECziJTc_GOTfybkU3H_S9r1nT5QTZQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Nov 25, 2016 at 4:32 AM, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> I have one more question,
>
> In V1 we were calling dsa_detach in ExecParallelCleanup and in
> ParallelQueryMain, but it's removed in v2.
>
> Any specific reason ?
> Does this need to be used differently ?
>
> ExecParallelCleanup(ParallelExecutorInfo *pei)
> {
> + if (pei->area != NULL)
> + {
> + dsa_detach(pei->area);
> + pei->area = NULL;
> + }
>
> After this changes, I am getting DSM segment leak warning.
Thanks! I had some chicken-vs-egg problems dealing with cleanup of
DSM segments belonging to DSA areas created inside DSM segments.
Here's a new version to apply on top of dsa-v7.patch.
--
Thomas Munro
http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
dsa-area-for-executor-v3.patch | application/octet-stream | 5.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2016-11-25 13:07:48 | Re: make default TABLESPACE belong to target table. |
Previous Message | Thomas Munro | 2016-11-25 12:48:56 | Re: Dynamic shared memory areas |