| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Numeric multiplication overflow errors |
| Date: | 2021-07-05 10:04:29 |
| Message-ID: | CAEZATCXhAzA-i+JF+9KCEEAY9L7WMnKwjHYjsq97ubEh4DGjbA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 4 Jul 2021 at 09:43, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Sat, 3 Jul 2021 at 11:04, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
> > Thinking about this more, I think it's best not to risk back-patching.
> > It *might* be safe, but it's difficult to really be sure of that. The
> > bug itself is pretty unlikely to ever happen in practice, hence the
> > lack of prior complaints, and in fact I only found it by an
> > examination of the code. So it doesn't seem to be worth the risk.
>
> That seems like good logic to me. Perhaps we can reconsider that
> decision if users complain about it.
Thanks. Pushed to master only.
I think the other part (avoiding overflows in numeric_mul) is fairly
straightforward and uncontentious, so barring objections, I'll push
and back-patch it in a couple of days or so.
Regards,
Dean
| Attachment | Content-Type | Size |
|---|---|---|
| numeric-mul-overflow-v3.patch | text/x-patch | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-07-05 10:17:16 | Re: psql - add SHOW_ALL_RESULTS option |
| Previous Message | Andrey Lepikhov | 2021-07-05 09:57:45 | Re: Asymmetric partition-wise JOIN |