From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Some optimisations for numeric division |
Date: | 2022-02-27 11:23:27 |
Message-ID: | CAEZATCW2zUGkWuQKMgYQzHhjc-XtXQD4B62Hhe_biUtJw2bWGA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, 25 Feb 2022 at 18:30, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> writes:
> > And another update following feedback from the cfbot.
>
> This patchset LGTM. On my machine there doesn't seem to be any
> measurable performance change for the numeric regression test,
> but numeric_big gets about 15% faster.
>
Yes, that matches my observations. Thanks for reviewing and testing.
> The only additional thought I have, based on your comments about
> 0001, is that maybe in mul_var we should declare var1digit as
> being NumericDigit not int. I tried that here and didn't see
> any material change in the generated assembly code (using gcc
> 8.5.0), so you're right that modern gcc doesn't need any help
> there; but I wonder if it could help on other compiler versions.
>
Yes, that makes sense. Done that way.
Regards,
Dean
From | Date | Subject | |
---|---|---|---|
Next Message | Dong Wook Lee | 2022-02-27 11:45:13 | pg_stat_statements: remove redundant function call in pg_stat_statements_internal |
Previous Message | Bharath Rupireddy | 2022-02-27 09:46:44 | Re: Is it worth adding ReplicationSlot active_pid to ReplicationSlotPersistentData? |