Re: Adding OLD/NEW support to RETURNING

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(at)vondra(dot)me>
Subject: Re: Adding OLD/NEW support to RETURNING
Date: 2025-01-17 10:44:03
Message-ID: CAEZATCVX2o0KP2ZKiROKB0cWGMGU_PVHiDk+jf2kCr0MH0dtzg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 17 Jan 2025 at 02:24, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
> It seems that adding ParseNamespaceItems for the OLD or NEW aliases
> may confuse scanNameSpaceForRelid() when searching the table namespace
> for a relation item. Since they contain the same RTE,
> scanNameSpaceForRelid() might mistakenly detect multiple matches.
>
> create table t (a int, b int);
>
> update public.t set a = 1 returning public.t.b;
> ERROR: table reference 46337 is ambiguous
> LINE 1: update public.t set a = 1 returning public.t.b;
> ^

Thanks. I hadn't tested qualified table names in the RETURNING list.
I've pushed a fix for that.

Regards,
Dean

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2025-01-17 11:00:39 Re: Fix misuse use of pg_b64_encode function (contrib/postgres_fdw/connection.c)
Previous Message Bertrand Drouvot 2025-01-17 10:23:48 Re: per backend I/O statistics