From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | amul sul <sulamul(at)gmail(dot)com> |
Cc: | Andreas Joseph Krogh <andreas(at)visena(dot)com>, PostgreSQL General <pgsql-general(at)postgresql(dot)org> |
Subject: | Re: Exclude pg_largeobject form pg_dump |
Date: | 2016-11-13 21:23:41 |
Message-ID: | CAECtzeXOTXGz9O6EJ=L4wYwARqW31bKo=j_bcDWe3pg5b8-i1w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
2016-11-08 6:01 GMT+01:00 amul sul <sulamul(at)gmail(dot)com>:
> On Tue, Nov 8, 2016 at 5:36 AM, Andreas Joseph Krogh <andreas(at)visena(dot)com>
> wrote:
> >
> >
> > I don't see what you mean. It forces dump of Blobs if we didn't use -B
> and
> > if we include everything in the dump, which seems good to me. What did
> you
> > try that didn't work as expected?
> >
> >
> > I guess what he means is that if -B is given, the following code sets
> > dopt.outputBlobs = false
> >
> > + case 'B': /* Don't dump blobs */
> > + dopt.outputBlobs = false;
> > + break;
> >
> >
> > Then this IF sets it back to TRUE:
> >
> > + if (dopt.include_everything && !dopt.schemaOnly &&
> !dopt.outputBlobs)
> > dopt.outputBlobs = true;
> >
> >
> > ...making it impossible to turn off dumping of blobs.
> >
>
> Yes, thats the reason v4 patch was not as expected.
>
>
It took me some time but I finally understand.
Behaviour fix in v6.
--
Guillaume.
http://blog.guillaume.lelarge.info
http://www.dalibo.com
Attachment | Content-Type | Size |
---|---|---|
noblobs_v6.patch | text/x-patch | 3.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | John R Pierce | 2016-11-13 21:27:58 | Re: pg_dumpall: could not connect to database "template1": FATAL: |
Previous Message | Adrian Klaver | 2016-11-13 21:12:27 | Re: pg_dumpall: could not connect to database "template1": FATAL: |
From | Date | Subject | |
---|---|---|---|
Next Message | Emre Hasegeli | 2016-11-13 21:41:01 | Re: Floating point comparison inconsistencies of the geometric types |
Previous Message | Rahila Syed | 2016-11-13 20:50:09 | Re: Improvements in psql hooks for variables |