From: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
---|---|
To: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add pgstathashindex() to get hash index table statistics. |
Date: | 2017-01-19 06:57:18 |
Message-ID: | CAE9k0PnX-taq5XYq8Pb64Nu4buRF1DyCcC-upE79K8NZbk42Zg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> However, I've some minor comments on the patch:
>
> +/*
> + * HASH_ALLOCATABLE_PAGE_SZ represents allocatable
> + * space (pd_upper - pd_lower) on a hash page.
> + */
> +#define HASH_ALLOCATABLE_PAGE_SZ \
> + BLCKSZ - \
> + (SizeOfPageHeaderData + sizeof(HashPageOpaqueData))
> My suggestion will be not to write "(pd_upper - pd_lower)" in the
> comment. You may write allocatable space on a empty hash page.
Accepted. Have changed the comment accordingly.
>
> + buf = ReadBufferExtended(rel, MAIN_FORKNUM, blkno,
> RBM_NORMAL, NULL);
> Use BAS_BULKREAD strategy to read the buffer.
>
okay, corrected. Please check the attached v3 patch with corrections.
With Regards,
Ashutosh Sharma
EnterpriseDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
0001-Add-pgstathashindex-to-pgstattuple-extension-v3.patch | invalid/octet-stream | 17.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | vinayak | 2017-01-19 07:04:38 | Re: Transactions involving multiple postgres foreign servers |
Previous Message | Ishii Ayumi | 2017-01-19 06:56:26 | Fix documentation typo |