| From: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pageinspect: Hash index support |
| Date: | 2017-02-09 18:11:15 |
| Message-ID: | CAE9k0PnJ=ps6JELp8re0O7quqTJDLNw8nSn9gHaeHFWd7=NQag@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I think you should just tighten up the sanity checking in the existing
> function _hash_ovflblkno_to_bitno rather than duplicating the code. I
> don't think it's called often enough for one extra (cheap) test to be
> an issue. (You should change the elog in that function to an ereport,
> too, since it's going to be a user-facing error message now.)
okay, I have taken care of above two points in the attached patch. Thanks.
| Attachment | Content-Type | Size |
|---|---|---|
| simplify_hash_bitmap_info_v3.patch | application/x-download | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-02-09 18:55:39 | Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal |
| Previous Message | Robert Haas | 2017-02-09 18:06:47 | Re: Parameterization of partial path |