From: | James Hilliard <james(dot)hilliard1(at)gmail(dot)com> |
---|---|
To: | David Steele <david(at)pgmasters(dot)net> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX. |
Date: | 2021-03-29 17:37:16 |
Message-ID: | CADvTj4qwmJgqWB5zStrPAxRL2DsPThtwOubAAUPUSh0XSY0JTw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Should it work if I just attach it to the thread like this?
On Mon, Mar 29, 2021 at 7:52 AM David Steele <david(at)pgmasters(dot)net> wrote:
>
> Hi James,
>
> On 1/31/21 1:59 AM, James Hilliard wrote:
> > On Fri, Jan 22, 2021 at 12:32 PM James Hilliard
> > <james(dot)hilliard1(at)gmail(dot)com> wrote:
> >>
> >> Fixes:
> >> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -O2 -I../../../../src/include -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk -c -o fd.o fd.c
> >> fd.c:3661:10: warning: 'pwritev' is only available on macOS 11.0 or newer [-Wunguarded-availability-new]
> >> part = pg_pwritev(fd, iov, iovcnt, offset);
> >> ^~~~~~~~~~
>
> It would be better to provide this patch as an attachment so the cfbot
> (http://commitfest.cputube.org/) can test it.
>
> Regards,
> --
> -David
> david(at)pgmasters(dot)net
Attachment | Content-Type | Size |
---|---|---|
v3-0001-Fix-detection-of-preadv-pwritev-support-for-OSX.patch | application/octet-stream | 12.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2021-03-29 17:38:16 | Re: Getting better results from valgrind leak tracking |
Previous Message | Fujii Masao | 2021-03-29 17:28:51 | Re: Get memory contexts of an arbitrary backend process |