From: | Dave Cramer <pg(at)fastcrypt(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status) |
Date: | 2019-10-16 05:48:39 |
Message-ID: | CADK3HHLPXK6m9_qt5s7cTSYC8CLnx0_dJFFa3E239KQTi87ZEA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, 12 Oct 2019 at 05:05, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2019-10-11 16:30:17 -0400, Robert Haas wrote:
> >> But, if it does need to be changed, it seems like a terrible idea to
> >> allow it to be done via SQL. Otherwise, the user can break the driver
> >> by using SQL to set the list to something that the driver's not
> >> expecting, and there's nothing the driver can do to prevent it.
>
> > Uhm. The driver can just ignore GUCs it's not interested in, like our
> > docs have told them for a long time?
>
> Certainly it should do that; but the problematic case is where it
> *doesn't* get told about something it's depending on knowing about.
>
> regards, tom lane
>
Here's an updated patch that addresses some of Andres' concerns
specifically does not use strtok.
As far as addressing connection poolers goes; one thought is to use the
cancellation key to "validate" the SQL.
This should be known to all drivers and pool implementations. Thoughts ?
Dave
Attachment | Content-Type | Size |
---|---|---|
0001-Add-a-STARTUP-packet-option-to-set-GUC_REPORT-on-GUC.patch | application/octet-stream | 7.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dilip Kumar | 2019-10-16 05:50:01 | Re: Questions/Observations related to Gist vacuum |
Previous Message | btendouan | 2019-10-16 05:36:19 | Re: pgbench - extend initialization phase control |