| From: | Dave Cramer <pg(at)fastcrypt(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status) |
| Date: | 2019-11-05 12:51:27 |
| Message-ID: | CADK3HHKE-Zj5P6rojBK0VB=Rgpi1UnaVYOQRVZ1oaSZZZ6t+mg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 3 Nov 2019 at 19:40, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Wed, Oct 16, 2019 at 6:49 PM Dave Cramer <pg(at)fastcrypt(dot)com> wrote:
> > Here's an updated patch that addresses some of Andres' concerns
> specifically does not use strtok.
>
> Hi Dave,
>
> I think you need to s/strncasecmp/pg_strncasecmp/ to make this build on
> Windows.
>
> https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.63963
Thomas,
Thanks for the review.
see attached
| Attachment | Content-Type | Size |
|---|---|---|
| 0002-user-pg_strncasecmp-for-windows-compatibility.patch | application/octet-stream | 785 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-11-05 13:12:12 | Re: v12 and pg_restore -f- |
| Previous Message | Dave Cramer | 2019-11-05 12:16:10 | Re: Binary support for pgoutput plugin |