From: | Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | David Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Proposal: knowing detail of config files via SQL |
Date: | 2015-01-31 06:20:05 |
Message-ID: | CAD21AoDs7wGMg6_3d4J-4+-drmuXpRcMXhvqf0B3QbbOcgMUmA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Jan 31, 2015 at 2:00 PM, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> wrote:
> On Sat, Jan 31, 2015 at 4:56 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> David Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
>>> On Fri, Jan 30, 2015 at 12:05 PM, David Fetter <david(at)fetter(dot)org> wrote:
>>>> Why might the contents of pg_settings be different from what would be
>>>> in pg_file_settings, apart from the existence of this column?
>>
>>> The contents of pg_settings uses the setting name as a primary key.
>>> The contents of pg_file_setting uses a compound key consisting of the
>>> setting name and the source file.
>>
>> [ raised eyebrow... ] Seems insufficient in the case that multiple
>> settings of the same value occur in the same source file. Don't you
>> need a line number in the key as well?
>>
>
> Yep, a line number is also needed.
> The source file and line number would be primary key of pg_file_settings view.
> I need to change like that.
>
Attached patch is latest version including following changes.
- This view is available to super use only
- Add sourceline coulmn
Also I registered CF app.
Regards,
-------
Sawada Masahiko
Attachment | Content-Type | Size |
---|---|---|
000_pg_file_settings_view_v2.patch | application/octet-stream | 7.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Sawada Masahiko | 2015-01-31 06:29:18 | Re: Proposal: knowing detail of config files via SQL |
Previous Message | Amit Kapila | 2015-01-31 06:01:24 | Re: Providing catalog view to pg_hba.conf file - Patch submission |