From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | "Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com> |
Cc: | Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Resume vacuum and autovacuum from interruption and cancellation |
Date: | 2019-08-29 07:36:37 |
Message-ID: | CAD21AoDHOFGFc+PxZd20SPKNtRt=mdHoxpMRHgapy7aDTyyS5w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Aug 27, 2019 at 2:55 PM Jamison, Kirk <k(dot)jamison(at)jp(dot)fujitsu(dot)com> wrote:
>
> On Monday, August 19, 2019 10:39 AM (GMT+9), Masahiko Sawada wrote:
> > Fixed.
> >
> > Attached the updated version patch.
>
> Hi Sawada-san,
>
> I haven't tested it with heavily updated large tables, but I think the patch
> is reasonable as it helps to shorten the execution time of vacuum by removing
> the redundant vacuuming and prioritizing reclaiming the garbage instead.
> I'm not sure if it's commonly reported to have problems even when we repeat
> vacuuming the already-vacuumed blocks, but I think it's a reasonable improvement.
>
> I skimmed the patch and have few comments. If they deem fit, feel free to
> follow, but it's also ok if you don't.
Thank you for reviewing this patch! I've attached the updated patch
incorporated all your comments and some improvements.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
v3-0001-Add-RESUME-option-to-VACUUM-and-autovacuum.patch | application/x-patch | 25.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Moon, Insung | 2019-08-29 08:19:51 | Wrong value in metapage of GIN INDEX. |
Previous Message | Fabien COELHO | 2019-08-29 07:24:11 | Re: BUG #15977: Inconsistent behavior in chained transactions |