From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Maxim Orlov <orlovmg(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [BUG] FailedAssertion in SnapBuildPurgeOlderTxn |
Date: | 2022-11-24 08:17:41 |
Message-ID: | CAD21AoD5k=PhEWjnEtwGrCrF0YuZJna5AGDRZHbnrAvhF=zOTA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Nov 23, 2022 at 12:00 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Nov 22, 2022 at 10:33 PM Maxim Orlov <orlovmg(at)gmail(dot)com> wrote:
> >>
> >>
> >> Regarding the tests, the patch includes a new scenario to
> >> reproduce this issue. However, since the issue can be reproduced also
> >> by the existing scenario (with low probability, though), I'm not sure
> >> it's worth adding the new scenario.
> >
> > AFAICS, the test added doesn't 100% reproduce this issue, so, maybe, it does not worth it. But, I do not have a strong opinion here.
> > Let's add tests in a separate commit and let the actual committer to decide what to do, should we?
> >
>
> +1 to not have a test for this as the scenario can already be tested
> by the existing set of tests.
Agreed not to have a test case for this.
I've attached an updated patch. I've confirmed this patch works for
all supported branches.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
Attachment | Content-Type | Size |
---|---|---|
0001-Reset-InitialRunningXacts-array-when-freeing-SnapBui.patch | application/octet-stream | 1.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | mahendrakar s | 2022-11-24 08:20:49 | Re: [PoC] Federated Authn/z with OAUTHBEARER |
Previous Message | Peter Eisentraut | 2022-11-24 08:11:31 | Re: doc: Fix description of how the default user name is chosen |