| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "amit(dot)kapila16(at)gmail(dot)com" <amit(dot)kapila16(at)gmail(dot)com>, "bdrouvot(at)amazon(dot)com" <bdrouvot(at)amazon(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "minsoo(at)amazon(dot)com" <minsoo(at)amazon(dot)com> |
| Subject: | Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns |
| Date: | 2022-08-03 07:49:24 |
| Message-ID: | CAD21AoCqpLvtw=_YwM3f7mB+_80a4CSOBp7Wmthvbh4tiUqywg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 3, 2022 at 3:52 PM shiy(dot)fnst(at)fujitsu(dot)com
<shiy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Wed, Aug 3, 2022 12:06 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > I've attached updated patches that incorporated the above comments as
> > well as the comments from Shi yu. Please review them.
> >
>
> Thanks for updating the patch.
>
> I noticed that in SnapBuildXidSetCatalogChanges(), "i" is initialized in the if
> branch in REL10 patch, which is different from REL11 patch. Maybe we can modify
> REL11 patch to be consistent with REL10 patch.
>
> The rest of the patch looks good to me.
Oops, thanks for pointing it out. I've fixed it and attached updated
patches for all branches so as not to confuse the patch version. There
is no update from v12 patch on REL12 - master patches.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| REL15_v13-0001-Fix-catalog-lookup-with-the-wrong-snapshot-durin.patch | application/octet-stream | 16.0 KB |
| master_v13-0001-Fix-catalog-lookup-with-the-wrong-snapshot-durin.patch | application/octet-stream | 29.3 KB |
| REL13_v13-0001-Fix-catalog-lookup-with-the-wrong-snapshot-durin.patch | application/octet-stream | 16.0 KB |
| REL12_v13-0001-Fix-catalog-lookup-with-the-wrong-snapshot-durin.patch | application/octet-stream | 16.0 KB |
| REL14_v13-0001-Fix-catalog-lookup-with-the-wrong-snapshot-durin.patch | application/octet-stream | 16.0 KB |
| REL11_v13-0001-Fix-catalog-lookup-with-the-wrong-snapshot-durin.patch | application/octet-stream | 15.9 KB |
| REL10_v13-0001-Fix-catalog-lookup-with-the-wrong-snapshot-durin.patch | application/octet-stream | 15.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Junwang Zhao | 2022-08-03 08:10:25 | [doc] fix a potential grammer mistake |
| Previous Message | Kyotaro Horiguchi | 2022-08-03 07:32:17 | Re: Does having pg_last_wal_replay_lsn[replica] >= pg_current_wal_insert_lsn[master] guarantee that the replica is caught up? |