Re: Skipping logical replication transactions on subscriber side

On Thu, Oct 14, 2021 at 5:45 PM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>
> On Tue, Oct 12, 2021 at 4:00 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > I've attached updated patches.
> >
>
> A couple more comments for some issues that I noticed in the v16 patches:
>
> v16-0002
>
> doc/src/sgml/ref/alter_subscription.sgml
>
> (1) Order of parameters that can be reset doesn't match those that can be set.
> Also, it doesn't match the order specified in the documentation
> updates in the v16-0003 patch.
>
> Suggested change:
>
> BEFORE:
> + The parameters that can be reset are: <literal>streaming</literal>,
> + <literal>binary</literal>, <literal>synchronous_commit</literal>.
> AFTER:
> + The parameters that can be reset are:
> <literal>synchronous_commit</literal>,
> + <literal>binary</literal>, <literal>streaming</literal>.
>

Fixed.

>
> v16-0003
>
> doc/src/sgml/ref/alter_subscription.sgml
>
> (1) Documentation update says "slot_name" is a parameter that can be
> reset, but this is not correct, it can't be reset.
> Also, the doc update is missing "the" before "parameter".
>
> Suggested change:
>
> BEFORE:
> + The parameters that can be reset are: <literal>slot_name</literal>,
> + <literal>synchronous_commit</literal>, <literal>binary</literal>,
> + <literal>streaming</literal>, and following parameter:
> AFTER:
> + The parameters that can be reset are:
> <literal>synchronous_commit</literal>,
> + <literal>binary</literal>, <literal>streaming</literal>, and
> the following
> + parameter:

Fixed.

I've attached updated patches that incorporate all comments I got so far.

Regards,

--
Masahiko Sawada
EDB: https://www.enterprisedb.com/