From: | Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Proposal : REINDEX xxx VERBOSE |
Date: | 2015-05-13 17:49:51 |
Message-ID: | CAD21AoAG733FtGJAaPOgoo=jHdkZZ1yWj=BfhXCfPK-NR3h3CQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, May 14, 2015 at 12:28 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, May 7, 2015 at 6:55 PM, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> Sorry, I forgot attach files.
>
> Review comments:
>
> - Customarily we use int, rather than uint8, for flags variables. I
> think we should do that here also.
>
> - reindex_index() emits a log message either way, but at DEBUG2 level
> without VERBOSE and at the INFO level with it. I think we should skip
> it altogether without VERBOSE. i.e. if (options & REINDEXOPT_VERBOSE)
> ereport(...)
>
> - The errmsg() in that function should not end with a period.
>
> - The 000 patch makes a pointless whitespace change to tab-complete.c.
>
> - Instead of an enumerated type (ReindexOption) just use #define to
> define the flag value.
>
> Apart from those fairly minor issues, I think this looks pretty solid.
>
Thank you for reviwing..
All fixed.
Regards,
-------
Sawada Masahiko
Attachment | Content-Type | Size |
---|---|---|
000_reindex_verbose_v14.patch | application/octet-stream | 14.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2015-05-13 18:10:46 | Re: Proposal : REINDEX xxx VERBOSE |
Previous Message | Heikki Linnakangas | 2015-05-13 17:23:59 | Re: Streaming replication and WAL archive interactions |