From: | Önder Kalacı <onderkalaci(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, Marco Slot <marco(dot)slot(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |
Date: | 2023-03-07 13:47:07 |
Message-ID: | CACawEhVo19_hP=Z1Z0ywDYY8=e1Fg8xz0PvMMBUAjwY8VbXp8g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Amit, Peter
> > > Let me give an example to demonstrate why I thought something is fishy
> here:
> > >
> > > Imagine rel has a (non-default) REPLICA IDENTITY with Oid=1111.
> > > Imagine the same rel has a PRIMARY KEY with Oid=2222.
> > >
>
Hmm, alright, this is syntactically possible, but not sure if any user
would do this. Still thanks for catching this.
And, you are right, if a user has created such a schema,
IdxIsRelationIdentityOrPK()
would return the wrong result and we'd use sequential scan instead of index
scan.
This would be a regression. I think we should change the function.
Here is the example:
DROP TABLE tab1;
CREATE TABLE tab1 (a int NOT NULL);
CREATE UNIQUE INDEX replica_unique ON tab1(a);
ALTER TABLE tab1 REPLICA IDENTITY USING INDEX replica_unique;
ALTER TABLE tab1 ADD CONSTRAINT pkey PRIMARY KEY (a);
I'm attaching v35.
Does that make sense to you Amit?
Attachment | Content-Type | Size |
---|---|---|
v35_0002_use_index_on_subs_when_pub_rep_ident_full.patch | application/octet-stream | 9.2 KB |
v35_0001_use_index_on_subs_when_pub_rep_ident_full.patch | application/octet-stream | 66.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2023-03-07 14:02:14 | Re: some problem explicit_bzero with building PostgreSQL on linux |
Previous Message | Aleksander Alekseev | 2023-03-07 13:18:13 | Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) |