| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com> |
| Cc: | Srinath Reddy <srinath2133(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Non-text mode for pg_dumpall |
| Date: | 2025-01-29 09:38:36 |
| Message-ID: | CACJufxGp5p7_7EwNwg-GuKZO+XB9uxfWTZ+QWhhNvwgUF0Vb0w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
hi.
we need to escape the semicolon within the single quotes or double quotes.
I think my patch in [1] is correct.
we can have "ERROR: role "z" already exists
but
error message like
pg_restore: error: could not execute query: "ERROR: unterminated
quoted string at or near "';
should not be accepted in execute_global_sql_commands, ReadOneStatement, PQexec
attached is the all the corner test case i come up with against
ReadOneStatement.
your v13 will generate errors like "ERROR: unterminated quoted string
at or near ..."',
which is not good, i think.
| Attachment | Content-Type | Size |
|---|---|---|
| global_object_quotes_escape_tests.sql | application/sql | 689 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shubham Khanna | 2025-01-29 09:43:55 | Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. |
| Previous Message | vignesh C | 2025-01-29 09:20:01 | Re: CREATE PUBLICATION and foreign partitions |