Re: Virtual generated columns

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Virtual generated columns
Date: 2024-09-16 09:22:29
Message-ID: CACJufxFM=K-h4ueryACtXoc_O-h_CvT3sLZ3t+21V8rTs8W+dw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

in v7.

doc/src/sgml/ref/alter_table.sgml
<phrase>and <replaceable
class="parameter">column_constraint</replaceable> is:</phrase>

section need representation of:
GENERATED ALWAYS AS ( <replaceable>generation_expr</replaceable> ) [VIRTUAL]

in RelationBuildTupleDesc(Relation relation)
we need to add "constr->has_generated_virtual" for the following code?

if (constr->has_not_null ||
constr->has_generated_stored ||
ndef > 0 ||
attrmiss ||
relation->rd_rel->relchecks > 0)

also seems there will be table_rewrite for adding virtual generated
columns, but we can avoid that.
The attached patch is the change and the tests.

i've put the tests in src/test/regress/sql/fast_default.sql,
since it already has event triggers and trigger functions, we don't
want to duplicate it.

Attachment Content-Type Size
v7-0001-Virtual-generated-columns-no-table_rewrite.no-cfbot application/octet-stream 4.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2024-09-16 09:25:42 Re: Allow logical failover slots to wait on synchronous replication
Previous Message Marlene Reiterer 2024-09-16 08:45:47 Re: Doc: Move standalone backup section, mention -X argument