| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Tender Wang <tndrwang(at)gmail(dot)com> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Wrong result when enable_partitionwise_join is on if collation of PartitionKey and Column is different. |
| Date: | 2024-10-30 03:57:35 |
| Message-ID: | CACJufxF1bmHSc+L7Hg7QxnH9UDbyP+qMsK8Z2ZBU8kux6C=t3A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I missed a case when column collation and partition key collation are
the same and indeterministic.
that should be fine for partition-wise join.
so v2 attached.
have_partkey_equi_join, match_expr_to_partition_keys didn't do any
collation related check.
propose v2 change disallow partitionwise join for case when
column collation is indeterministic *and* is differ from partition
key's collation.
the attached partition_wise_join_collation.sql is the test script.
you may use it to compare with the master behavior.
| Attachment | Content-Type | Size |
|---|---|---|
| partition_wise_join_collation.sql | application/sql | 8.1 KB |
| v2-0001-partition_wise_join_collation_check.diff | text/x-patch | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hunaid Sohail | 2024-10-30 06:07:27 | Re: Psql meta-command conninfo+ |
| Previous Message | Michael Paquier | 2024-10-30 03:40:05 | Re: Add isolation test template in injection_points for wait/wakeup/detach |