From: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
---|---|
To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Japin Li <japinli(at)hotmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
Subject: | Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) |
Date: | 2023-11-09 16:22:11 |
Message-ID: | CACG=ezaOGAAmzqKjq=EDyqA6jNVtNFVvTc6-HstEy43swRqTog@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Aleksander Alekseev,
> Maxim,
> I see both of us accounted for Alexanders feedback and submitted v59.
> Your newer version seems to have issues on cfbot, so resubmitting the
> previous patchset that passes the tests. Please feel free to add
> changes.
For unknown reasons, I do not receive any of your emails from after
2023-11-07 11:57:12 (Message-ID: CAJ7c6TN1hKqNPGrNcq96SUyD=
Z61raKGXF8iqq36qr90oudxRg(at)mail(dot)gmail(dot)com).
Even after resend.
Anyway, PFA patch set of version 61. I've made some minor changes in the
0001 and add 004 in order to test actual 64-bit SLRU pages.
As for CF bot had failed on my v59 patch set, this is because of the bug.
It's manifested because of added 64-bit pages tests.
The problem was in segno calculation, since we convert it from file name
using strtol call. But strtol return long,
which is 4 byte long in x86.
- segno = (int) strtol(clde->d_name, NULL, 16);
+ segno = strtoi64(clde->d_name, NULL, 16);
--
Best regards,
Maxim Orlov.
Attachment | Content-Type | Size |
---|---|---|
v61-0003-Make-use-FullTransactionId-in-2PC-filenames.patch | application/octet-stream | 2.9 KB |
v61-0004-Add-SLRU-tests-for-64-bit-page-case.patch | application/octet-stream | 5.5 KB |
v61-0002-Use-larger-segment-file-names-for-pg_notify.patch | application/octet-stream | 13.0 KB |
v61-0001-Index-SLRUs-by-64-bit-integers-rather-than-by-32.patch | application/octet-stream | 56.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | shihao zhong | 2023-11-09 16:29:12 | Re: Postgres Partitions Limitations (5.11.2.3) |
Previous Message | Heikki Linnakangas | 2023-11-09 16:18:21 | Re: Speed up transaction completion faster after many relations are accessed in a transaction |