From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
---|---|
To: | Arthur Zakirov <zaartur(at)gmail(dot)com> |
Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Allow to_date() and to_timestamp() to accept localized names |
Date: | 2020-01-15 18:21:11 |
Message-ID: | CAC+AXB2a6ei0mPFG7h-NaiBVO5=tKT67rONZmrDzoOcAE-B2Sg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jan 15, 2020 at 11:20 AM Arthur Zakirov <zaartur(at)gmail(dot)com> wrote:
>
> I have some couple picky notes.
>
>
Thanks for the review.
> > + if (name_len != norm_len)
> > + pfree(norm_name);
>
> I'm not sure here. Is it save to assume that if it was allocated a new
> norm_name name_len and norm_len always will differ?
>
Good call, that check can be more robust.
>
> > static const char *const months_full[] = {
> > "January", "February", "March", "April", "May", "June", "July",
> > - "August", "September", "October", "November", "December", NULL
> > + "August", "September", "October", "November", "December"
> > };
>
> Unfortunately I didn't see from the patch why it was necessary to remove
> last null element from months_full, days_short, adbc_strings,
> adbc_strings_long and other arrays. I think it is not good because
> unnecessarily increases the patch and adds code like the following:
>
> > + from_char_seq_search(&value, &s, months,
> localized_names,
> > +
> ONE_UPPER, MAX_MON_LEN, n, have_error,
> > +
> lengthof(months_full));
>
> Here it passes "months" from datetime.c to from_char_seq_search() and
> calculates its length using "months_full" array from formatting.c.
>
With the introduction of seq_search_localized() that can be avoided,
minimizing code churn.
Please, find attached a version addressing the above mentioned.
Regards,
Juan José Santamaría Flecha
>
>
Attachment | Content-Type | Size |
---|---|---|
0001-Allow-localized-month-names-to_date-v6.patch | application/octet-stream | 13.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David Zhang | 2020-01-15 18:35:38 | Re: Making psql error out on output failures |
Previous Message | Tom Lane | 2020-01-15 18:12:56 | Re: Rearranging ALTER TABLE to avoid multi-operations bugs |