From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Emil Iggland <emil(at)iggland(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: BUG #15858: could not stat file - over 4GB |
Date: | 2020-10-10 11:31:21 |
Message-ID: | CAC+AXB0g44SbvSpC86o_1HWh8TAU2pZrMRW6tJT-dkijotx5Qg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Fri, Oct 9, 2020 at 10:22 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Emil Iggland <emil(at)iggland(dot)com> writes:
> > I tested the patch at hand, and it performs as expected. Files larger
> than 4GB can be imported.
>
> Thanks for testing!
>
Thanks for testing! +1
>
> I'd been expecting one of our Windows-savvy committers to pick this up,
> but since nothing has been happening, I took it on myself to push it.
> I'll probably regret that :-(
>
Thanks for taking care of this. I see no problems in the build farm, but
please reach me if I missed something.
>
> I made a few cosmetic changes, mostly reorganizing comments in a way
> that made more sense to me.
>
> I was working on a new version, which was pgindent-friendlier and clearer
about reporting an error when 'errno' is not informed. Please find attached
a patch with those changes.
Regards,
Juan José Santamaría Flecha
Attachment | Content-Type | Size |
---|---|---|
0001-win32stat-indent-and-errormapping-v1.patch | application/octet-stream | 2.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2020-10-10 11:55:25 | Re: BUG #16665: Segmentation fault |
Previous Message | Raphael Megzari | 2020-10-10 11:27:13 | Re: BUG #16665: Segmentation fault |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2020-10-10 11:55:42 | Re: Parallel INSERT (INTO ... SELECT ...) |
Previous Message | Tomas Vondra | 2020-10-10 11:29:35 | Re: WIP: WAL prefetch (another approach) |