Re: Conflict detection for multiple_unique_conflicts in logical replication

On Fri, Mar 21, 2025 at 3:38 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Mar 21, 2025 at 1:48 PM Zhijie Hou (Fujitsu)
> <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > On Fri, Mar 21, 2025 at 12:50 PM Nisha Moond wrote:
> >
> > > Thanks, Hou-san, for the review and fix patches. I’ve incorporated
> > > your suggestions.
> > > Attached are the v7 patches, including patch 002, which implements
> > > stats collection for 'multiple_unique_conflicts' in pg_stat_subscription_stats.
> >
> > Thanks for updating the patches.
> >
> > Here are some more comments:
> >
> > 1.
> >
> > The comments atop of ReportApplyConflict() should be updated to reflect the
> > updates made to the input parameters.
> >
>
> Right, I also noticed this and updated it in the attached. Apart from
> this, I have made a number of cosmetic changes in the attached. Please
> review and include it in the next version unless you see any problem
> with it.
>

Thanks for the review.

I’ve incorporated the changes and also addressed Hou-san’s comments
from [1] with suggested changes.

Attached are the v8 patches.

[1] https://www.postgresql.org/message-id/OS0PR01MB57169BA3CB76A79B30223E3894DB2%40OS0PR01MB5716.jpnprd01.prod.outlook.com

--
Thanks,
Nisha