From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Prevent printing "next step instructions" in initdb and pg_upgrade |
Date: | 2021-01-17 13:38:14 |
Message-ID: | CABUevEzeGRWYh3N9UEa_tEBKF4E0sd0TVBj0TVtfvvPWFT1FBQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jan 7, 2021 at 11:53 AM Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> After pondering this again, I think we can go with initdb
> --no-instructions, as in your patch.
>
> As a minor nitpick, I would leave out the
>
> else
> printf(_("\nSuccess.\n"));
>
> in the --no-instructions case.
OK, thanks. I have applied it as such, with that message moved inside
the if statement.
> (I don't know where the pg_upgrade part of this discussion is right now.)
Yeah, I think that one turned into quite a different discussion. I
think it's clear to say that the part of this patch related to
pg_upgrade was rejected - I'll drop that one. I think pg_upgrade
scripts has to be thought about as a completely separate thing, so
let's leave that for another thread.
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2021-01-17 13:48:04 | cgit view availabel |
Previous Message | Magnus Hagander | 2021-01-17 13:07:07 | Re: Add session statistics to pg_stat_database |