From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | David Steele <david(at)pgmasters(dot)net> |
Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Checksum errors in pg_stat_database |
Date: | 2019-02-22 14:00:47 |
Message-ID: | CABUevExj9RaZdqnu2q+oMBcB_mZAd2iBzEuZw4+-VQmJw4byRg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Jan 12, 2019 at 5:16 AM David Steele <david(at)pgmasters(dot)net> wrote:
> On 1/11/19 10:25 PM, Magnus Hagander wrote:
> > On Fri, Jan 11, 2019 at 9:20 PM Tomas Vondra
> > On 1/11/19 7:40 PM, Robert Haas wrote:
> > > But I'm tentatively in favor of your proposal anyway, because it's
> > > pretty simple and cheap and might help people, and doing something
> > > noticeably better is probably annoyingly complicated.
> > >
> >
> > +1
> >
> > Yeah, that's the idea behind it -- it's cheap, and an
> > early-warning-indicator.
>
> +1
>
PFA is a patch to do this.
It tracks things that happen in the general backends. Possibly we should
also consider counting the errors actually found when running base backups?
OTOH, that part of the code doesn't really track things like databases (as
it operates just on the raw data directory underneath), so that
implementation would definitely not be as clean...
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
Attachment | Content-Type | Size |
---|---|---|
stat_checksums.patch | text/x-patch | 8.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2019-02-22 14:03:39 | Re: Remove Deprecated Exclusive Backup Mode |
Previous Message | Antonin Houska | 2019-02-22 13:54:29 | Re: Problems with plan estimates in postgres_fdw |