From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | Vladimir Rusinov <vrusinov(at)google(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Make pg_basebackup -x stream the default |
Date: | 2016-12-17 14:37:33 |
Message-ID: | CABUevEwz7mHVXoj5zf1_zkBMJrwZ9-iXj_Q445XBCdF4D4U=Tg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Dec 16, 2016 at 6:35 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Fri, Dec 16, 2016 at 11:36 PM, Magnus Hagander <magnus(at)hagander(dot)net>
> wrote:
> > On Thu, Dec 15, 2016 at 12:37 AM, Vladimir Rusinov <vrusinov(at)google(dot)com>
> > wrote:
> >>
> >> Usability review
> >>
> >> ============
> >>
> >>
> >> Patch sounds like a good idea and does what it supposed to do. /me in
> DBA
> >> hat will be happy to have it.
> >>
> >> However, it makes '-x' parameter a bit confusing/surprising: specifying
> it
> >> will be equivalent to '-X fetch' which is surprising regression from
> the new
> >> default.
> >
> >
> > This seems like a good idea, really.
> >
> > Given that we already break a number of other things around backups and
> > replication in this release, it seems like a good time.
> >
> > I definitely think removing it is what we should do -- let's not
> redefine it
> > to mean streaming, let's just get rid of -x altogether, and have people
> use
> > -X streaming|fetch|none.
> >
> > What do others feel about this?
>
> +1 to drop -x option. That's less confusing.
>
Attached is an updated patch that does this. As a bonus it simplifies the
code a bit. I also fixed an error message that I missed updating in the
previous patch.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
Attachment | Content-Type | Size |
---|---|---|
basebackup_stream_default.patch | text/x-patch | 7.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2016-12-17 14:41:15 | Re: [PATCH] Remove trailing whitespaces from documentation |
Previous Message | Magnus Hagander | 2016-12-17 13:52:41 | Re: Proposal for changes to recovery.conf API |