From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Bernd Helmle <mailings(at)oopsware(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: SSL information view |
Date: | 2015-04-12 17:12:50 |
Message-ID: | CABUevEwcQ3exhmFdsJ_nO-Nxg57Vr4hnJ0s1d90cD3Xz6_88mw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Apr 10, 2015 at 2:14 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:
> On Fri, Apr 10, 2015 at 6:39 PM, Magnus Hagander wrote:
> >> +typedef struct PgBackendSSLStatus
> >> +{
> >> + /* Information about SSL connection */
> >> + int ssl_bits;
> >> + bool ssl_compression;
> >> + char ssl_version[NAMEDATALEN]; /* MUST be
> >> null-terminated */
> >> + char ssl_cipher[NAMEDATALEN]; /* MUST be
> >> null-terminated */
> >> + char ssl_clientdn[NAMEDATALEN]; /* MUST be
> >> null-terminated */
> >> +} PgBackendSSLStatus;
> >> git diff is showing in red here, spaces should be replaced with a tab.
> >
> >
> > Ugh. Fixed. One too many copy/pastes I think.
> >
>
> You forgot one here:
> + /* Information about SSL connection */
>
In other news, I have now fixed my git to show these things to be again. It
used to do that, but I broke it :)
Thanks!
Except for those style comments (feel free to ignore them), I tested
> the patch and it is doing what it claims. As I don't have more
> comments, let's switch that to "Ready for Committer" then...
>
Ok. Thanks - and patch applied!
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2015-04-12 19:02:38 | Re: Replication identifiers, take 4 |
Previous Message | Simon Riggs | 2015-04-12 13:30:45 | Re: TABLESAMPLE patch |