From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Race conditions with WAL sender PID lookups |
Date: | 2017-05-20 12:40:57 |
Message-ID: | CAB7nPqSTsnK+b53s-NZUuTPosJmjbV+zKHV3zHr7K6ZKFMVY_A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, May 19, 2017 at 3:01 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> Also, as Horiguchi-san pointed out earlier, walreceiver seems need the
> similar fix.
Actually, now that I look at it, ready_to_display should as well be
protected by the lock of the WAL receiver, so it is incorrectly placed
in walreceiver.h. As you are pointing out, pg_stat_get_wal_receiver()
is lazy as well, and that's new in 10, so we have an open item here
for both of them. And I am the author for both things. No issues
spotted in walreceiverfuncs.c after review.
I am adding an open item so as both issues are fixed in PG10. With the
WAL sender part, I think that this should be a group shot.
So what do you think about the attached?
--
Michael
Attachment | Content-Type | Size |
---|---|---|
walsnd-pid-races-v3.patch | text/x-patch | 6.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David G. Johnston | 2017-05-20 16:31:06 | Re: Allowing dash character in LTREE |
Previous Message | Noah Misch | 2017-05-20 12:26:33 | Re: OK, so culicidae is *still* broken |