Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013

On Sun, Dec 4, 2016 at 5:58 AM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> On Wed, Nov 30, 2016 at 04:24:34PM +0000, Christian Ullrich wrote:
>> * From: Michael Paquier
>> > would be nice to mention in a code comment that this what Noah has
>> > mentioned upthread: if a CRT loads while pgwin32_putenv() is
>> > executing, the newly-loaded CRT will always have the latest value.
>>
>> I fixed the existing comment by removing the last sentence that is in the wrong place now, but I don't see the point in suddenly starting to explain why it is done this way and not the other.
>>
>> > Based on that 0006 will need a rebase, nothing huge though.
>>
>> Done, new revisions attached.
>
> I committed patches 1-7 with some comment changes, a pgindent, and other
> cosmetic trivia. (The file was pgindent-clean before this work. Patch 6
> still achieved the more-compact formatting you sought.)

Thanks all for helping in closing this item. We have a fine result here.
--
Michael