From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
---|---|
To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Reduce the number of special cases to build contrib modules on windows |
Date: | 2021-07-28 12:05:43 |
Message-ID: | CAApHDvr3shY1YO97b519DXVjxnu1adZFGv2B6UhYeOTGuNKWtA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, 28 Jul 2021 at 03:52, Dagfinn Ilmari Mannsåker
<ilmari(at)ilmari(dot)org> wrote:
>
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > I think using the return value of grep as a boolean is confusing. It
> > seems more legible to compare to 0. So instead of this:
> >
> > + if (! grep { $_ eq $ref} @{ $self->{references} })
> > + {
> > + push @{ $self->{references} }, $ref;
> > + }
> >
> > use something like:
> >
> > + if (grep { $_ eq $ref} @{ $self->{references} } == 0)
>
> I disagree. Using grep in boolean context is perfectly idiomatic perl.
> What would be more idiomatic is List::Util::any, but that's not availble
> without upgrading List::Util from CPAN on Perls older than 5.20, so we
> can't use that.
Ok, if the grep stuff is ok as is with the boolean comparison then I'd
say 0002 and 0003 of the attached are ok to go.
I pushed the v9 0001 and 0005 patch after adjusting the AddFile($self,
...) to become $self->AddFile(...)
I've adjusted the attached 0001 patch (previously 0002) to define
LOWER_NODE in ltree.h as mentioned by Tom.
0004 still needs work.
Thanks for all the reviews.
David
Attachment | Content-Type | Size |
---|---|---|
v10-0001-Adjust-MSVC-build-scripts-to-parse-Makefiles-for.patch | application/octet-stream | 3.9 KB |
v10-0002-Make-the-includes-field-an-array-in-MSVC-build-s.patch | application/octet-stream | 2.7 KB |
v10-0003-Don-t-duplicate-references-and-libraries-in-MSVC.patch | application/octet-stream | 1.3 KB |
v10-0004-Remove-some-special-cases-from-MSVC-build-script.patch | application/octet-stream | 4.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | osumi.takamichi@fujitsu.com | 2021-07-28 12:56:52 | RE: Failed transaction statistics to measure the logical replication progress |
Previous Message | torikoshia | 2021-07-28 11:44:00 | Re: RFC: Logging plan of the running query |