From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
---|---|
To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
Cc: | Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Window Function "Run Conditions" |
Date: | 2022-04-07 14:11:06 |
Message-ID: | CAApHDvq=UfYDnEB5eBEXjsNg-HvpFazZYSGbTzqp9iGicgMqww@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, 7 Apr 2022 at 19:01, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Thu, 7 Apr 2022 at 15:41, Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> > + * We must keep the original qual in place if there is a
> > + * PARTITION BY clause as the top-level WindowAgg remains in
> > + * pass-through mode and does nothing to filter out unwanted
> > + * tuples.
> > + */
> > + *keep_original = false;
> >
> > The comment talks about keeping original qual but the assignment uses the value false.
> > Maybe the comment can be rephrased so that it matches the assignment.
>
> Thanks. I've just removed that comment locally now. You're right, it
> was out of date.
I've attached the updated patch with the fixed comment and a few other
comments reworded slightly.
I've also pgindented the patch.
Barring any objection, I'm planning to push this one in around 10 hours time.
David
Attachment | Content-Type | Size |
---|---|---|
v7-0001-Teach-planner-and-executor-about-monotonic-window.patch | text/plain | 78.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bharath Rupireddy | 2022-04-07 14:15:24 | New function(s) to get various timelines that the postgres server deals with. |
Previous Message | Tom Lane | 2022-04-07 14:05:15 | Re: Extensible Rmgr for Table AMs |