From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
---|---|
To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
Cc: | Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Wired if-statement in gen_partprune_steps_internal |
Date: | 2021-04-08 08:34:28 |
Message-ID: | CAApHDvq1tdUw_Qo9PnHfnHBzpJewFaWkH5jxggiPRB7JsxOX1w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, 8 Apr 2021 at 00:49, Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
>
> Thanks David. Actually, I was busy updating the patch to revert to
> gen_partprune_steps_internal() returning a list and was almost done
> with it when I saw your message.
>
> I read through v3 and can say that it certainly looks better than v2.
> If you are happy with gen_partprune_steps_internal() no longer
> returning a list, I would not object if you wanted to go ahead and
> commit the v3.
>
> I've attached the patch I had ended up with and was about to post as
> v3, just in case you wanted to glance.
Thanks. I've made a pass over that and just fixed up the places that
were mixing up NIL and NULL.
I applied most of my comments from my last version after adapting them
to account for the variation in the functions return value. I also did
a bit more explaining about op steps and combine steps in the header
comment for gen_partprune_steps_internal.
Patch attached.
David
Attachment | Content-Type | Size |
---|---|---|
v5_fixup_partprune_dgr.patch | application/octet-stream | 11.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2021-04-08 09:00:34 | Re: Change JOIN tutorial to focus more on explicit joins |
Previous Message | Julien Rouhaud | 2021-04-08 08:33:18 | Re: Typo in jsonfuncs.c |