From: | Jacob Champion <jchampion(at)timescale(dot)com> |
---|---|
To: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [PATCH] minor reloption regression tests improvement |
Date: | 2022-06-30 23:16:24 |
Message-ID: | CAAWbhmiuRnNo1Xfd2VvbK0-3YrU7bCwnHXTSOpnLiWd9+5cMnA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jun 29, 2022 at 9:04 PM Nikolay Shaplov <dhyan(at)nataraj(dot)su> wrote:
> В письме от четверг, 30 июня 2022 г. 06:47:48 MSK пользователь Nikolay Shaplov
> написал:
>
> > Hi! I am surely feel this patch is important. I have bigger patch
> > https://commitfest.postgresql.org/38/3536/ and this test makes sense as a
> > part of big work of options refactoring,
> >
> > I am also was strongly advised to commit things chopped into smaller parts,
> > when possible. This test can be commit separately so I am doing it.
>
> Let me again explain why this test is importaint, so potential reviewers can
> easily find this information.
>
> Tests are for developers. You change the code and see that something does not
> work anymore, as it worked before.
> When you change the code, you should keep both documented and undocumented
> behaviour. Because user's code can intentionally or accidentally use it.
[developer hat] Right, but I think Greg also pointed out the tradeoff
here, and my understanding was that he didn't feel that the tradeoff
was enough. If this is related to a bigger refactoring, it may be
easier to argue the test's value if it's discussed there? (This could
be frustrating if you've just been told to split things up, sorry.)
[CFM hat] Since you feel strongly about the patch, and we're short on
time before the commitfest starts, I have re-registered this. That way
there can be an explicit decision as opposed to a pocket veto by me.
https://commitfest.postgresql.org/38/3747/
Thanks,
--Jacob
From | Date | Subject | |
---|---|---|---|
Next Message | Jacob Champion | 2022-06-30 23:26:54 | Re: [PoC] Let libpq reject unexpected authentication requests |
Previous Message | Peter Geoghegan | 2022-06-30 22:40:23 | Re: doc: Clarify what "excluded" represents for INSERT ON CONFLICT |