From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
Cc: | Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Parallel leader process info in EXPLAIN |
Date: | 2020-01-17 20:25:49 |
Message-ID: | CAAKRu_aUeT25JdJjoM=jqp3h40b2gXe40u39Dhd7BzNxtKhDCQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Both patches aren't applying cleanly anymore.
The first patch in the set applied cleanly for me before b925a00f4ef65
It mostly seems like the default settings for the patch program were
my problem, but, since I noticed that the patch tester bot was failing
to apply it also, I thought I would suggest rebasing it.
I applied it to the sha before b925a00f4ef65 and then cherry-picked it
to master and it applied fine. I attached that rebased patch with a
new version number (is that the preferred way to indicate that it is
newer even if it contains no new content?).
The second patch in the set needed a bit more looking at to rebase,
which I didn't do yet.
I played around with the first patch in the patchset and very much
appreciate seeing the leaders contribution.
However, I noticed that there were no EXPLAIN diffs in any test files
and just wondered if this was a conscious choice (even with xxx the
actual numbers, I would have thought that there would be an EXPLAIN
VERBOSE with leader participation somewhere in regress).
--
Melanie Plageman
Attachment | Content-Type | Size |
---|---|---|
0001-Show-parallel-leader-stats-in-EXPLAIN-output-v4.patch | application/octet-stream | 18.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Verite | 2020-01-17 20:39:07 | Re: psql - add SHOW_ALL_RESULTS option |
Previous Message | David Fetter | 2020-01-17 20:15:29 | Re: Let people set host(no)ssl settings from initdb |