| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Shayon Mukherjee <shayonj(at)gmail(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Benoit Lobréau <benoit(dot)lobreau(at)gmail(dot)com>, Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal to Enable/Disable Index using ALTER INDEX (with patch) |
| Date: | 2025-04-01 18:41:17 |
| Message-ID: | CAA5RZ0vs-zfYPc4aDmg8uTzbpgdh7vVdH8rf_KLrxX1CGP+_1w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I went back to look at this patch and a few things. I noticed it did
not have correct
indentation, so I ran pgindent. I also removed some extra lines added and made
some slight adjustments to the docs. Attached my edited patch as a txt. If you
agree, please revise into a v14.
I also noticed that between v12 and v13, the GUC use_invisible_index
was removed,
but I don't see a discussion as to why. I feel it's a good GUC to have
[0], and we should
at least have it as a separate patch as part of this set.
I will continue reviewing the patch, but i feel this may be close to
be marked RFC, although
not sure if it will get a committer review before code freeze.
--
Sami Imseih
Amazon Web Services (AWS)
| Attachment | Content-Type | Size |
|---|---|---|
| sami-v13-edits.txt | text/plain | 48.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-04-01 18:44:14 | Re: Statistics Import and Export |
| Previous Message | Noah Misch | 2025-04-01 18:39:51 | Re: Small memory fixes for pg_createsubcriber |