From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com> |
Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [Patch] Optimize dropping of relation buffers using dlist |
Date: | 2020-12-24 14:07:17 |
Message-ID: | CAA4eK1LYAL=5SvPxY3sRkRJZorR31p4J=MGvd=VfEA_Xo4ORWg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Dec 23, 2020 at 6:27 PM k(dot)jamison(at)fujitsu(dot)com
<k(dot)jamison(at)fujitsu(dot)com> wrote:
>
>
> It compiles. Passes the regression tests too.
> Your feedbacks are definitely welcome.
>
Thanks, the patches look good to me now. I have slightly edited the
patches for comments, commit messages, and removed the duplicate
code/check in smgrnblocks. I have changed the order of patches (moved
Assert related patch to last because as mentioned earlier, I am not
sure if we want to commit it.). We might still have to change the scan
threshold value based on your and Tang-San's results.
--
With Regards,
Amit Kapila.
Attachment | Content-Type | Size |
---|---|---|
v38-0001-Optimize-DropRelFileNodeBuffers-for-recovery.patch | application/octet-stream | 12.1 KB |
v38-0002-Optimize-DropRelFileNodesAllBuffers-for-recovery.patch | application/octet-stream | 6.3 KB |
v38-0003-Prevent-invalidating-blocks-in-smgrextend-during.patch | application/octet-stream | 1.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2020-12-24 14:13:29 | Re: postgres_fdw - cached connection leaks if the associated user mapping/foreign server is dropped |
Previous Message | Jammie | 2020-12-24 14:00:30 | Re: Movement of restart_lsn position movement of logical replication slots is very slow |