Re: PG compilation error with Visual Studio 2015/2017/2019

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
Cc: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, davinder singh <davindersingh2692(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG compilation error with Visual Studio 2015/2017/2019
Date: 2020-05-06 04:40:54
Message-ID: CAA4eK1Ku41-gzt4NfL0EPyjpwU6__rqYv-rB2_APyXbT-mSQ4Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 6, 2020 at 4:19 AM Juan José Santamaría Flecha
<juanjo(dot)santamaria(at)gmail(dot)com> wrote:
>
> On Tue, May 5, 2020 at 1:34 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>
>>
>> Apart from that, I have made a few other changes in comments, fixed
>> typos, and ran pgindent. Let me know what do you think of attached
>> patches?
>
>
> The patches are definitely in better shape.
>
> I think that the definition of get_iso_localename() should be consistent across all versions, that is HEAD like back-patched.
>

Fair enough. I have changed such that get_iso_localename is the same
in HEAD as it is backbranch patches. I have attached backbranch
patches for the ease of verification.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
0001-PG-compilation-error-with-VS-2015-2017-2019_v17.patch application/x-patch 10.6 KB
0001-PG9_5-compilation-error-with-VS-2015-2017-2019_v16.patch application/x-patch 8.3 KB
0001-PG_10-compilation-error-with-VS-2015-2017-2019_v16.patch application/x-patch 8.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2020-05-06 05:36:21 Re: PG 13 release notes, first draft
Previous Message 邱宇航 2020-05-06 03:05:06 Re: Optimization for hot standby XLOG_STANDBY_LOCK redo