| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel safety for extern params |
| Date: | 2017-10-28 14:32:23 |
| Message-ID: | CAA4eK1K7Tkn28p+jO6_pVD7BZSOR3j6_bu5s1XE5H+-5=_S-TA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Oct 28, 2017 at 2:02 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, Oct 16, 2017 at 12:59 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> When I tried back-porting the patch to v10 I discovered that the
> plpgsql changes conflict heavily and that ripping them out all the way
> produces regression failures under force_parallel_mode. I think I see
> why that's happening but it's not obvious how to me how to adapt
> b73f1b5c29e0ace5a281bc13ce09dea30e1b66de to the v10 code. Do you want
> to have a crack at it or should we just leave this as a master-only
> fix?
>
I think we need to make changes in exec_simple_recheck_plan to make
the behavior similar to HEAD. With the attached patch, all tests
passed with force_parallel_mode.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| fix_parallel_safety_for_extern_params_v2.patch | application/octet-stream | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2017-10-28 14:56:49 | Re: proposal: schema variables |
| Previous Message | Chris Travers | 2017-10-28 14:24:43 | Re: proposal: schema variables |