| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alexander Kuzmenkov <a(dot)kuzmenkov(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: heap_lock_updated_tuple_rec can leak a buffer refcount |
| Date: | 2018-03-03 04:45:14 |
| Message-ID: | CAA4eK1JvyFx9wy_6UBCAcMi94nNtRZnk_1eenyvwex4Oy9dBzA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 3, 2018 at 3:26 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alexander Kuzmenkov <a(dot)kuzmenkov(at)postgrespro(dot)ru> writes:
>> Looks like a leak indeed, the fix seems right.
>
>
> Hence, I propose the attached patch. The test lobotomization
> (the "if (1) //" change) isn't meant for commit but shows how I tested
> the take-the-pin paths. This passes make check-world with or without
> the lobotomization change.
>
Thanks for taking care of this.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-03-03 04:48:55 | Re: non-bulk inserts and tuple routing |
| Previous Message | Andres Freund | 2018-03-03 04:38:18 | Re: non-bulk inserts and tuple routing |