Re: [BUG]Update Toast data failure in logical replication

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUG]Update Toast data failure in logical replication
Date: 2022-02-04 12:15:36
Message-ID: CAA4eK1J0_THjhCcgXOxnfyZ+a63K7i+G3FOA8TWaOQ2xkthPbg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 31, 2022 at 9:03 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> >
> > I have changed this and various other comments in the patch. I have
> > modified the docs as well to reflect the changes. I thought of adding
> > a test but I think the current test in toast.sql seems sufficient.
> > Kindly let me know what you think of the attached? I think we should
> > backpatch this till v10. What do you think?
>
> Looks fine to me.
>

Attached are the patches for back-branches till v10. I have made two
modifications: (a) changed heap_tuple_attr_equals() to
heap_attr_equals() as we are not passing tuple to it; (b) changed
parameter name 'check_external_cols' to 'external_cols' to make it
sound similar to existing parameter 'interesting_cols' in
HeapDetermine* function.

Let me know what you think of the attached? Do you see any reason not
to back-patch this fix?

--
With Regards,
Amit Kapila.

Attachment Content-Type Size
HEAD-v7-0001-WAL-log-unchanged-toasted-replica-identity-key-at.patch application/octet-stream 13.8 KB
14-v7-0001-WAL-log-unchanged-toasted-replica-identity-key-a.patch application/octet-stream 13.8 KB
13-v7-0001-WAL-log-unchanged-toasted-replica-identity-key-a.patch application/octet-stream 13.8 KB
12-v7-0001-WAL-log-unchanged-toasted-replica-identity-key-a.patch application/octet-stream 13.8 KB
11-v7-0001-WAL-log-unchanged-toasted-replica-identity-key-a.patch application/octet-stream 13.0 KB
10-v7-0001-WAL-log-unchanged-toasted-replica-identity-key-a.patch application/octet-stream 12.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-02-04 12:20:46 Re: Bugs in pgoutput.c
Previous Message Pavel Stehule 2022-02-04 11:45:05 Re: Deparsing rewritten query