| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Amul Sul <sulamul(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options |
| Date: | 2021-07-01 11:07:50 |
| Message-ID: | CAA4eK1+-vwkVLkmgeLCWx55Ea_5A0Mqpw2sqi+jYdpM0is0kWA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 30, 2021 at 7:38 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> PFA v9 patch set for further review.
>
The first patch looks mostly good to me. I have made some minor
modifications to the 0001 patch: (a) added/edited few comments, (b)
there is no need to initialize supported_opts variable in
CreateSubscription, (c) used extra bracket in macro, (d) ran pgindent.
Kindly check and let me know what you think of the attached? I am not
sure whether second patch is an improvement over what we have
currently but if you and others feel that is a good idea then you can
submit the same after the main patch gets committed.
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-Refactor-function-parse_subscription_options.patch | application/octet-stream | 27.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-07-01 11:20:14 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Fabien COELHO | 2021-07-01 10:47:57 | Re: pgbench: INSERT workload, FK indexes, filler fix |