From: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: range_agg |
Date: | 2020-01-17 20:07:54 |
Message-ID: | CA+renyVfMGDpuXjx=jUjUaw2euqkQLEDazkZhjs76qOXN0ocwA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jan 10, 2020 at 1:38 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> This still leaves the question of how best to format the docs for
>> these operators. I like being able to combine all the <@ variations
>> (e.g.) into one table row, but if that is too ugly I could give them
>> separate rows instead. Giving them all their own row consumes a lot of
>> vertical space though, and to me that makes the docs more tedious to
>> read & browse, so it's harder to grasp all the available range-related
>> operations at a glance.
>
>
> I have similar opinion - maybe is better do documentation for range and multirange separately. Sometimes there are still removed operators @+
I like keeping the range/multirange operators together since they are
so similar for both types, but if others disagree I'd be grateful for
more feedback.
You're right that I left in a few references to the old @+ style
operators in the examples; I've fixed those.
> If you can share TYPTYPE_RANGE in code for multiranges, then it should be 'r'. If not, then it needs own value.
Okay. I think a new 'm' value is warranted because they are not interchangeable.
>> I experimented with setting pg_type.typelem to the multirange's range
>> type, but it seemed to break a lot of things, and reading the code I
>> saw some places that treat a non-zero typelem as synonymous with being
>> an array. So I'm reluctant to make this change also, especially when
>> it is just as easy to query pg_range to get a multirange's range type.
>
>
> ok, it is unhappy, but it is true. This note should be somewhere in code, please
I've added a comment about this. I put it at the top of DefineRange
but let me know if that's the wrong place.
The attached file is also rebased on currrent master.
Thanks!
Paul
Attachment | Content-Type | Size |
---|---|---|
v9-multirange.patch | application/octet-stream | 331.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David Fetter | 2020-01-17 20:15:29 | Re: Let people set host(no)ssl settings from initdb |
Previous Message | David Fetter | 2020-01-17 19:47:49 | Re: Let people set host(no)ssl settings from initdb |